mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46318: Added helper to create test agent with injected `Authorizer`.
Date Fri, 22 Apr 2016 14:05:33 GMT


> On April 22, 2016, 9:42 a.m., Adam B wrote:
> > src/tests/mesos.hpp, line 210
> > <https://reviews.apache.org/r/46318/diff/1/?file=1348100#file1348100line210>
> >
> >     How do you know this is the set of parameters your helper will need? Why don't
you need a containerizer, etc.?

The general pattern for the existing `MesosTest::StartSlave` overloads seems to be to allow
injecting just one specific aspect; if a user needs to inject more she would call `cluster::Slave::start`
directly. The added overload tries to follow that spirit.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130053
-----------------------------------------------------------


On April 22, 2016, 4:04 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In addition to the fully generic interface we do provide a number of
> short hand functions for creating agents in tests which allow injecting
> just a single component. Add one such short hand function for creating
> a test agent with an injected `Authorizer` which we will use in a
> subsequent patch.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 
>   src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb 
> 
> Diff: https://reviews.apache.org/r/46318/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message