mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 46318: Added helper to create test slave with injected `Authorizer`.
Date Fri, 22 Apr 2016 07:42:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130053
-----------------------------------------------------------



Please add a bit more motivation to the description, especially if it's a precursor patch
that I'd review before getting to the meat where it's actually used. While this patch would
compile if committed on its own, it seems useless/pointless without something calling the
new method.


src/tests/mesos.hpp (line 210)
<https://reviews.apache.org/r/46318/#comment193672>

    How do you know this is the set of parameters your helper will need? Why don't you need
a containerizer, etc.?


- Adam B


On April 18, 2016, 4:15 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 4:15 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 
>   src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb 
> 
> Diff: https://reviews.apache.org/r/46318/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message