mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 46340: Stout:[1/2] Implement `os::waitpid`.
Date Fri, 22 Apr 2016 01:21:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46340/#review130013
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 254)
<https://reviews.apache.org/r/46340/#comment193625>

    start with a capital.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 268 - 269)
<https://reviews.apache.org/r/46340/#comment193624>

    new line.


- Joris Van Remoortere


On April 20, 2016, 9:51 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46340/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 9:51 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4466
>     https://issues.apache.org/jira/browse/MESOS-4466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[1/2] Implement `os::waitpid`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46340/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message