mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 45674: Implemented recover() for dvd isolator.
Date Fri, 22 Apr 2016 01:11:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130011
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 121)
<https://reviews.apache.org/r/45674/#comment193619>

    add apace before `should`



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 122 - 124)
<https://reviews.apache.org/r/45674/#comment193620>

    Let's add a VLOG(1).



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 223)
<https://reviews.apache.org/r/45674/#comment193621>

    ditto.


- Gilbert Song


On April 21, 2016, 2:13 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5104
>     https://issues.apache.org/jira/browse/MESOS-5104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented recover() for dvd isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 
>   src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955

>   src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5

>   src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45674/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message