mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.
Date Thu, 21 Apr 2016 17:36:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review129922
-----------------------------------------------------------




include/mesos/appc/spec.proto (line 62)
<https://reviews.apache.org/r/46182/#comment193475>

    Todo comment style is `TODO(name): <text>`. Also we end comments with period.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 199)
<https://reviews.apache.org/r/46182/#comment193481>

    Why this variable?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 202)
<https://reviews.apache.org/r/46182/#comment193478>

    indentation.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 203)
<https://reviews.apache.org/r/46182/#comment193479>

    recommend better name for the variable `manifest1`



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 213)
<https://reviews.apache.org/r/46182/#comment193480>

    This could return the default contructed ImageManifest object if none of the images's
manifest could be found.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 307)
<https://reviews.apache.org/r/46182/#comment193476>

    Fix indentation



src/slave/containerizer/mesos/provisioner/store.hpp (line 26)
<https://reviews.apache.org/r/46182/#comment193477>

    headers should be alphabetically sorted.


- Jojy Varghese


On April 15, 2016, 6:23 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -----
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 5c96e9f6603d39889e6bc807874d35d0cb3556be

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546

>   src/slave/containerizer/mesos/provisioner/store.hpp 1d477ef13ddd24fd8badae0decaa4a2271ecc746

> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> -------
> 
> make check on linux passes AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message