mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.
Date Thu, 21 Apr 2016 02:08:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/#review129828
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp (lines 25 - 29)
<https://reviews.apache.org/r/43985/#comment193364>

    Let's keep these separate. They're indepedent blocks with independent semantics.
    
    ```
    #ifdef __WINDOWS__
    #include <stout/windows/error.hpp>
    #endif  // __WINDOWS__
    
    using SocketError =
    #ifdef __WINDOWS_
      WindowsSocketError;
    #else
      ErrnoError;
    #endif  // __WINDOWS__
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp (line 37)
<https://reviews.apache.org/r/43985/#comment193362>

    Backticks around `Try<ssize_t, ErrnoError>`, and `ErrnoError` should be `SocketError`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp (line 64)
<https://reviews.apache.org/r/43985/#comment193360>

    By "Here and below", I mean these should have also be updated to `return SocketError();`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp (line 76)
<https://reviews.apache.org/r/43985/#comment193361>

    By "Here and below", I mean these should have also be updated to `return SocketError();`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
<https://reviews.apache.org/r/43985/#comment193363>

    Please add this back.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 35)
<https://reviews.apache.org/r/43985/#comment193365>

    Where did the `& MAXDWORD` come from, and why?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 43)
<https://reviews.apache.org/r/43985/#comment193366>

    I requested to return `SocketError` here, it's marked as resolved but it doesn't seem
so.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 119 - 121)
<https://reviews.apache.org/r/43985/#comment193373>

    


- Michael Park


On April 20, 2016, 4:45 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43985/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 4:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [1/4] Implemented `sendfile`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp cd1bad14919b9d566d5201201d8c3b4a335d5b9f

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 293f82f6730551491504721e0af28e9537540db1

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp f3197679a9c22b37acae003262e5c6d21e110f56

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 750ca6749cb028703ed2fb5dec2aac6c5dabea0d

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp d634491b301632ce6468f86d04f21fa25afbbaaa

> 
> Diff: https://reviews.apache.org/r/43985/diff/
> 
> 
> Testing
> -------
> 
> Build Windows,
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message