mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".
Date Wed, 20 Apr 2016 13:51:40 GMT


> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 143
> > <https://reviews.apache.org/r/46097/diff/1/?file=1341409#file1341409line143>
> >
> >     Can we make the task long running, and then check that the CNI network information
has been correctly checkpointed in the host file system.
> 
> Qian Zhang wrote:
>     If the output of the CNI plugin is not correctly checkpointed for the container,
then we should receive a TASK_FAILED rather than TASK_RUNNING or TASK_FINISHED which are expected
by this test, so I think this test already catches this, right?

Posted a separate patch for it: https://reviews.apache.org/r/46435/


> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 146
> > <https://reviews.apache.org/r/46097/diff/1/?file=1341409#file1341409line146>
> >
> >     Can we check if the checkpointed information is correctly cleaned up after the
the TASK has finished.
> 
> Qian Zhang wrote:
>     Ditto.

Posted a separate patch for it: https://reviews.apache.org/r/46435/


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review128446
-----------------------------------------------------------


On April 20, 2016, 9:47 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46097/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
>     https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46097/diff/
> 
> 
> Testing
> -------
> 
> $ sudo make check GTEST_FILTER="CniIsolatorTest.ROOT_LaunchCommandTask"
> ...
> [ RUN      ] CniIsolatorTest.ROOT_LaunchCommandTask
> + /home/stack/workspace/mesos/build/src/mesos-containerizer mount --help=false --operation=make-rslave
--path=/
> + + + cut -d grep -f5
>  -v 28c5b811-5154-4718-9c4d-e76c1bc50ca8
> + xargs --no-run-if-empty umount -l
> grep -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_Pjsz7G/.+ /proc/self/mountinfo
> + mount -n --rbind /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_Pjsz7G/provisioner/containers/28c5b811-5154-4718-9c4d-e76c1bc50ca8/backends/copy/rootfses/7dd027f8-3753-4afc-bae3-1334390a62d0
/tmp/CniIsolatorTest_ROOT_LaunchCommandTask_Pjsz7G/slaves/4743c920-1501-4e91-9be0-aa801d7d210f-S0/frameworks/4743c920-1501-4e91-9be0-aa801d7d210f-0000/executors/e1b3e486-d8f4-478a-9880-adfd02131ace/runs/28c5b811-5154-4718-9c4d-e76c1bc50ca8/.rootfs
> I0420 21:43:34.856003  6701 exec.cpp:150] Version: 0.29.0
> I0420 21:43:34.873869  6776 exec.cpp:225] Executor registered on agent 4743c920-1501-4e91-9be0-aa801d7d210f-S0
> Registered executor on mesos
> Starting task e1b3e486-d8f4-478a-9880-adfd02131ace
> Forked command at 6778
> [/bin/ls, ls, -al, /]
> total 56
> drwxr-xr-x   17 root     root          4096 Apr 20 13:43 .
> drwxr-xr-x   17 root     root          4096 Apr 20 13:43 ..
> drwxr-xr-x    2 root     root          4096 Apr  1 18:56 bin
> drwxr-xr-x    4 root     root           280 Apr 20 13:43 dev
> drwxr-xr-x   13 root     root          4096 Apr 20 13:43 etc
> drwxr-xr-x    2 root     root          4096 Apr  1 18:56 home
> drwxr-xr-x    5 root     root          4096 Apr  1 18:56 lib
> lrwxrwxrwx    1 root     root            12 Apr  1 18:56 linuxrc -> /bin/busybox
> drwxr-xr-x    5 root     root          4096 Apr  1 18:56 media
> drwxr-xr-x    3 root     root          4096 Apr 20 13:43 mnt
> dr-xr-xr-x  156 root     root             0 Apr 17 08:03 proc
> drwx------    2 root     root          4096 Apr  1 18:56 root
> drwxr-xr-x    2 root     root          4096 Apr  1 18:56 run
> drwxr-xr-x    2 root     root          4096 Apr  1 18:56 sbin
> dr-xr-xr-x   13 root     root             0 Apr 17 08:01 sys
> drwxrwxrwt    2 root     root          4096 Apr  1 18:56 tmp
> drwxr-xr-x    7 root     root          4096 Apr  1 18:56 usr
> drwxr-xr-x   10 root     root          4096 Apr  1 18:56 var
> Command exited with status 0 (pid: 6778)
> I0420 21:43:35.042424  6772 exec.cpp:399] Executor asked to shutdown
> [       OK ] CniIsolatorTest.ROOT_LaunchCommandTask (41169 ms)
> ...
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message