mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45360: Added volume driver client for mount and unmount.
Date Wed, 20 Apr 2016 09:25:46 GMT


> On 四月 14, 2016, 10:41 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp, line 46
> > <https://reviews.apache.org/r/45360/diff/7/?file=1343857#file1343857line46>
> >
> >     Why virtual? Let's not make them virtual yet.

I was following the docker way here: https://github.com/apache/mesos/blob/master/src/docker/docker.hpp#L53

Also we need to be virtual as `deleting object of polymorphic class type 'mesos::internal::slave::DockerVolumeDriverClient'
which has non-virtual destructor might cause undefined behaviour` (Got from compiler)


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/#review129016
-----------------------------------------------------------


On 四月 15, 2016, 2:43 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45360/
> -----------------------------------------------------------
> 
> (Updated 四月 15, 2016, 2:43 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added volume driver client for mount and unmount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45360/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message