mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <>
Subject Re: Review Request 46373: Request /files/read.json with a negative length value causes error.
Date Wed, 20 Apr 2016 05:57:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 四月 20, 2016, 5:57 a.m.)

Review request for mesos, Ben Mahler and Greg Mann.


rebased and updated the code according to Greg's comments

Bugs: mesos-5060

Repository: mesos

Description (updated)

The patch did the following changes:
1. Fix the length logic in files.cpp.
2. Add some tests to test the /files/read.json endponit with
negative length.

Diffs (updated)

  src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
  src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 



make check

request 'files/read.json' endpoint with negative offset or length argument


zhou xing

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message