mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 45905: Added metrics to the balloon framework.
Date Tue, 19 Apr 2016 21:52:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/
-----------------------------------------------------------

(Updated April 19, 2016, 2:52 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Changes
-------

Update/rebase based on changes in previous reviews.


Bugs: MESOS-5174
    https://issues.apache.org/jira/browse/MESOS-5174


Repository: mesos


Description
-------

Adds metrics to gauge the health of the framework.  This includes:

* uptime_secs = How long the framework has been running.
* registered = If the framework is registered.
* tasks_finished = Number of tasks finished (successfully).
* tasks_oomed = Number of tasks that were OOM killed.
* allowed_terminations = Number of terminal status updates which
  are acceptable due to infrastructure reasons.
* abnormal_terminations = Number of terminal status updates which 
  were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.


Diffs (updated)
-----

  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 

Diff: https://reviews.apache.org/r/45905/diff/


Testing
-------

```
make check

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"

# Also launched two instances on a cluster.
# This one OOM's:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint --balloon_limit=256MB
--task_memory=128MB --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos
&& ./balloon-executor"

# This one does not OOM:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint --balloon_limit=256MB
--task_memory=256MB --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos
&& ./balloon-executor"
```


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message