mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45326: Implemented os::which().
Date Tue, 19 Apr 2016 15:03:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review129540
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 467)
<https://reviews.apache.org/r/45326/#comment192959>

    Should we return error here? I mean use Result<std::string>.



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 975)
<https://reviews.apache.org/r/45326/#comment192962>

    Do we need test the priority here? When a binary exists in different folders at the same
time.



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 976)
<https://reviews.apache.org/r/45326/#comment192960>

    Should `EXPECT_SOME` here?


- haosdent huang


On April 19, 2016, 2:56 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 2:56 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4576
>     https://issues.apache.org/jira/browse/MESOS-4576
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented os::which().
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp dfe4eab2d812ef807c7416ac205573d55383c4ee

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266

> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> [ RUN      ] OsTest.Which
> [       OK ] OsTest.Which (0 ms)
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message