mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.
Date Tue, 19 Apr 2016 09:32:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46314/
-----------------------------------------------------------

(Updated April 19, 2016, 11:32 a.m.)


Review request for mesos, Zhiwei Chen and Vinod Kone.


Changes
-------

Updated CMakeLists.txt to apply protobuf patch.


Bugs: MESOS-4678
    https://issues.apache.org/jira/browse/MESOS-4678


Repository: mesos


Description (updated)
-------

This adds the upstream patch `717f807` which is contained in `protobuf-3.0.0-alpha-1`.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/CMakeLists.txt 7b3621d24a05a3b3b860e3b8c13a1531208e5e26 
  3rdparty/libprocess/3rdparty/protobuf-2.6.1.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/46314/diff/


Testing
-------

Building with GCC6 w/o this patch leads to a hard failure to a comparison between a signed
and unsigned types; with this patch the build succeeds.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message