mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 46149: Speed up DynamicReservationFramework.
Date Tue, 19 Apr 2016 03:59:17 GMT


> On April 14, 2016, 7:56 p.m., Benjamin Bannier wrote:
> > This is much better, but still long. I see that now most of the time is spent in
`resourceOffers` -- can you think of a way to speed these up as well?
> 
> Klaus Ma wrote:
>     @Bannier, how did you check the time in `resourceOffers`?
> 
> Benjamin Bannier wrote:
>     I looked at the verbose log -- and obviously cannot convert microseconds to seconds
(duh). The time seems to be spent elsewhere.
> 
> Klaus Ma wrote:
>     There're ~3s in allocator: we'll launch 5 tasks on 3 agents, one task per agent once
on reserved resources; so scheduler need `RESERVE`, `LAUNCH` and `UNRESERVE` to interact with
master. I think we can reduce allocator interval.

@bbannier/@mcypark :).


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46149/#review128877
-----------------------------------------------------------


On April 14, 2016, 8:59 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46149/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Bugs: MESOS-5166
>     https://issues.apache.org/jira/browse/MESOS-5166
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> **Phenomenon**: The runtime of "ExamplesTest.DynamicReservationFramework" is ~13s
> **Root Cause**: In dynamic reservation example, the framework will accept offer when
reserving resources, launching tasks and unreserving tasks. The un-used resources will return
to allocator with 5s RefusedFilters. It impact the performance of this example.
> **How to Fix**: Set filters.refused_timeout to zero when launching task, reserving/unreserving
resources.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc

> 
> Diff: https://reviews.apache.org/r/46149/diff/
> 
> 
> Testing
> -------
> 
> make && make check GTEST_FILTER="ExamplesTest.*"
> 
> [==========] Running 5 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 5 tests from ExamplesTest
> [ RUN      ] ExamplesTest.TestFramework
> [       OK ] ExamplesTest.TestFramework (5252 ms)
> [ RUN      ] ExamplesTest.NoExecutorFramework
> [       OK ] ExamplesTest.NoExecutorFramework (5407 ms)
> [ RUN      ] ExamplesTest.TestHTTPFramework
> [       OK ] ExamplesTest.TestHTTPFramework (1265 ms)
> [ RUN      ] ExamplesTest.PersistentVolumeFramework
> [       OK ] ExamplesTest.PersistentVolumeFramework (3379 ms)
> [ RUN      ] ExamplesTest.DynamicReservationFramework
> [       OK ] ExamplesTest.DynamicReservationFramework (5127 ms)
> [----------] 5 tests from ExamplesTest (20433 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 5 tests from 1 test case ran. (20443 ms total)
> [  PASSED  ] 5 tests.
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message