mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 34646: Redirect to the leader master when current master is not a leader.
Date Tue, 19 Apr 2016 01:45:33 GMT


> On April 18, 2016, 9:18 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 1030-1033
> > <https://reviews.apache.org/r/34646/diff/10/?file=1347710#file1347710line1030>
> >
> >     Why strip the url.path in this case?

Because we want to avoid the loop here. Suppose user open auto redirect, and he send `/redirect`
to the leader master. Then he would fall into infinite loop here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review129436
-----------------------------------------------------------


On April 16, 2016, 5:15 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34646/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, Neil Conway,
and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
>     https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this changes, we redirect to the leader master in those http
> endpoints which depend on master elected status if current master is
> not a leader.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d83ccd394c688803369034e22de79b40277a3a7c 
> 
> Diff: https://reviews.apache.org/r/34646/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> when current master is not a leader, it would redirect to the leader master.
> 
> ```
> $ curl -i http://master1:5050/master/tasks.json
> HTTP/1.1 307 Temporary Redirect
> Date: Mon, 01 Jun 2015 06:30:08 GMT
> Location: http://master2:5050//master/tasks.json
> Content-Length: 0
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message