mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.
Date Tue, 19 Apr 2016 00:09:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45317/#review129451
-----------------------------------------------------------




src/tests/mesos.hpp (lines 932 - 935)
<https://reviews.apache.org/r/45317/#comment192865>

    Yikes, this case isn't actually unreachable!
    
    Per MESOS-2664 and MESOS-3754, please avoid 'default' in favor of an explicit 'case UNKNOWN'
so that the compiler helps us catch all switches when we introduce a new enum value.


- Ben Mahler


On March 25, 2016, 8:55 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45317/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5014
>     https://issues.apache.org/jira/browse/MESOS-5014
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix changes Call and Event Type enums in scheduler.proto
> optional for the purpose of backwards compatibility. (MESOS-5014)
> 
> 
> Diffs
> -----
> 
>   CHANGELOG fef0cbfc3ae282707569429d38e52c19d4eb9aba 
>   include/mesos/scheduler/scheduler.proto 0049e1383f50574c3dad6a29b91811001694e82c 
>   include/mesos/v1/scheduler/scheduler.proto 09fafedd06837f2307fedc6fa0e7b4460b21e5b0

>   src/master/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578 
>   src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 
> 
> Diff: https://reviews.apache.org/r/45317/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message