mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.
Date Mon, 18 Apr 2016 18:11:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46314/#review129384
-----------------------------------------------------------



Looks good to me. Is there already a bug reported for this in the protobuf project? If not,
can you create one and link it here?

Also, this review is incomplete. There has to be corresponding changes in the Makefiles and
CMake files to apply this patch. Look how other patches are applied for reference.

- Vinod Kone


On April 18, 2016, 8:06 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46314/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and Vinod Kone.
> 
> 
> Bugs: MESOS-4678
>     https://issues.apache.org/jira/browse/MESOS-4678
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46314/diff/
> 
> 
> Testing
> -------
> 
> Building with GCC6 w/o this patch leads to a hard failure to a comparison between a signed
and unsigned types; with this patch the build succeeds.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message