mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 46295: Replaced 'using namespace' with 'using'.
Date Sun, 17 Apr 2016 16:48:12 GMT


> On April 16, 2016, 9:41 p.m., Jie Yu wrote:
> > src/log/log.cpp, lines 742-744
> > <https://reviews.apache.org/r/46295/diff/2/?file=1347521#file1347521line742>
> >
> >     Can you move this to the top of the file?
> 
> Kapil Arya wrote:
>     That won't work right away coz LogProcess, etc. are declared in this file. So to
move it up, I'll have to either do a forward declaration for these classes or move the definitions
to a separate header. Any preference?

Created https://reviews.apache.org/r/46308/ to handle this.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/#review129255
-----------------------------------------------------------


On April 17, 2016, 12:47 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46295/
> -----------------------------------------------------------
> 
> (Updated April 17, 2016, 12:47 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
>     https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mostly for mesos::state and mesos::log.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 4fd43ca31c6917e81ea1b331b8507ca42a2249cf

>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp fb3c5418220f66c6320581033ee7963de47eafd3

>   src/java/jni/org_apache_mesos_state_LogState.cpp 528fe5367f55c63916cd4990abcc3c137e77cfec

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec

>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46295/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message