mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <>
Subject Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.
Date Sun, 17 Apr 2016 15:11:21 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 17, 2016, 3:11 p.m.)

Review request for mesos, Ben Mahler, Neil Conway, and Timothy Chen.

Bugs: MESOS-1802

Repository: mesos


We need to ignore subsequent status updates in HealthStatusChange
tests. In our test cases, we set `consecutive_failures` to 3 in
HealthCheck message definition. But the counter for
`consecutiveFailures` in `mesos-health-check` would be reset to 0 after
a success check. It is possible to continue to receive status updates
before we stop the driver.


  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 


Testing (updated)

# I still could not reproduce the problem in old code after repeatedly tests. So seems no
way to verify whether my assumption is correct or not.


haosdent huang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message