mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46295: Replaced 'using namespace' with 'using'.
Date Sun, 17 Apr 2016 01:41:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/#review129255
-----------------------------------------------------------


Fix it, then Ship it!





src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp (lines 29 - 33)
<https://reviews.apache.org/r/46295/#comment192703>

    What's the ordering. Should we put 'using std::string' first as it's from library? I see
some in consistency on this. Let's be consistent.



src/log/log.cpp (lines 742 - 744)
<https://reviews.apache.org/r/46295/#comment192702>

    Can you move this to the top of the file?



src/state/log.cpp (lines 56 - 62)
<https://reviews.apache.org/r/46295/#comment192704>

    I like this ordering. Can you stick to this ordering in other files?



src/tests/state_tests.cpp (lines 73 - 79)
<https://reviews.apache.org/r/46295/#comment192705>

    Not yours, but mind pulling this up (no in the namespace braces).


- Jie Yu


On April 16, 2016, 1:27 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46295/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
>     https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced 'using namespace' with 'using'.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 4fd43ca31c6917e81ea1b331b8507ca42a2249cf

>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp fb3c5418220f66c6320581033ee7963de47eafd3

>   src/java/jni/org_apache_mesos_state_LogState.cpp 528fe5367f55c63916cd4990abcc3c137e77cfec

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec

>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46295/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message