mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.
Date Fri, 15 Apr 2016 23:31:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129204
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 294)
<https://reviews.apache.org/r/46013/#comment192660>

    Should we use `SharedHandle` here?



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 312 - 313)
<https://reviews.apache.org/r/46013/#comment192661>

    `} else {`



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 359)
<https://reviews.apache.org/r/46013/#comment192663>

    What's the difference between `Failed to call X` vs `Call to `X` failed`?



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 403 - 404)
<https://reviews.apache.org/r/46013/#comment192667>

    I think it would easier to read:
    
    ```
    Try<Duration> utime = Nanoseconds(lKernelTime.QuadPart * 100);
    Try<Duration> stime = Nanoseconds(lUserTime.QuadPart * 100);
    ```
    
    This is also arguably more correct, since any number < 10,000,000 would incorrectly
result in 0 by the division.
    
    What do you think?


- Michael Park


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
>     https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message