mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.
Date Fri, 15 Apr 2016 08:01:51 GMT


> On April 14, 2016, 9:19 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61
> > <https://reviews.apache.org/r/46014/diff/3/?file=1343687#file1343687line43>
> >
> >     Do we have plans to implement this in stout?

We do not. We could, but no one really needs it right now. Do you think we should?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/#review128989
-----------------------------------------------------------


On April 15, 2016, 8:01 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46014/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 8:01 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
>     https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[1/2] Moved process tests to their own file.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b

>   3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266

> 
> Diff: https://reviews.apache.org/r/46014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message