mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.
Date Fri, 15 Apr 2016 02:19:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/#review129058
-----------------------------------------------------------




src/CMakeLists.txt (line 62)
<https://reviews.apache.org/r/46245/#comment192510>

    You should update it, right?
    
    Can you make sure you test the patch using cmake? Thanks!


- Jie Yu


On April 15, 2016, 2:09 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46245/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed Docker and CNI BASE_NAME to meaningful name.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
> 
> Diff: https://reviews.apache.org/r/46245/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message