mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 46192: Stout:[1/2] Added `systems_tests.cpp`.
Date Thu, 14 Apr 2016 21:59:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46192/#review129006
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/tests/os/systems_tests.cpp (lines 41 - 45)
<https://reviews.apache.org/r/46192/#comment192469>

    I understand that these are new tests, but are they only true for Windows? or is it general
enough that we can pull it out of the Windows section?
    
    ```
    EXPECT_GT(info.get().release.size(), 0);
    ```
    
    would be better, or maybe:
    
    ```
    EXPECT_FALSE(info.get().release.empty());
    ```


- Michael Park


On April 14, 2016, 8:28 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46192/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
>     https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[1/2] Added `systems_tests.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b

>   3rdparty/libprocess/3rdparty/stout/tests/os/systems_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266

> 
> Diff: https://reviews.apache.org/r/46192/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message