mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 45604: Updated the balloon framework and executor.
Date Thu, 14 Apr 2016 21:44:53 GMT


> On April 12, 2016, 3:46 p.m., Vinod Kone wrote:
> > src/examples/balloon_framework.cpp, lines 69-90
> > <https://reviews.apache.org/r/45604/diff/2/?file=1337948#file1337948line69>
> >
> >     The interaction between these flags is a bit unclear.
> >     
> >     If some doesn't set `task_memory` but sets `balloon_limit`, the container might
or might not OOM. It depends on how much is offerred to the scheduler. I would rather make
this a required field. Infact, I would also add a required flag for executor memory (--executor_memory).
> >     
> >     Also s/balloon_limit/executor_memory_usage/ for clarity.
> 
> Joseph Wu wrote:
>     I did it this way to maintain the existing behavior (which I agree doesn't make very
much sense).

Note: I renamed to `--task_memory_usage_limit`.


> On April 12, 2016, 3:46 p.m., Vinod Kone wrote:
> > src/examples/balloon_framework.cpp, line 330
> > <https://reviews.apache.org/r/45604/diff/2/?file=1337948#file1337948line330>
> >
> >     This comment doesn't make sense?

Oops, removed.  That was a copy-paste :)


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review128539
-----------------------------------------------------------


On April 14, 2016, 2:43 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45604/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 2:43 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5174
>     https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives the example `balloon-framework` enough options to run
> outside of the build environment.
> 
> This also updates:
> 
> * The style of the framework code.
> * Adds an option for restricting the number of resources per task
>   (otherwise, it will eat up an entire node).
> * Adds an option for persisting the framework and launching one task
>   after another.
> * Adds filters for declined offers.
> * Refines the shutdown logic for the executor.  In particular, ironed 
>   out bugs when the balloon executor does not exceed the memory limit.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
> 
> Diff: https://reviews.apache.org/r/45604/diff/
> 
> 
> Testing
> -------
> 
> ```
> make check 
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message