mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.
Date Thu, 14 Apr 2016 21:10:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review128983
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 155)
<https://reviews.apache.org/r/46013/#comment192436>

    Remove newline.



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 161)
<https://reviews.apache.org/r/46013/#comment192435>

    `s/foreach(/foreach (/`



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 173 - 183)
<https://reviews.apache.org/r/46013/#comment192434>

    (1) It seems like this should live in `posix/os.hpp`.
    (2) The declaration of this function in `windows/os.hpp` is:
    ```
    inline Result<Process> process(pid_t pid);
    ```
    It seems like the windows version needs all 3 states whereas the POSIX version only needs
2?
    If that is the case, I think it makes sense to consolidate to using `Result` in both cases
and
    leave a comment on the POSIX version that we have the 3 states because of Windows.



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 200)
<https://reviews.apache.org/r/46013/#comment192439>

    `s/foreach(/foreach (/`



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 202)
<https://reviews.apache.org/r/46013/#comment192440>

    Indent 2 more spaces.



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 214)
<https://reviews.apache.org/r/46013/#comment192441>

    `s/> >/>>/`



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 217)
<https://reviews.apache.org/r/46013/#comment192442>

    Remove newline.


- Michael Park


On April 14, 2016, 8:57 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:57 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
>     https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message