mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.
Date Thu, 14 Apr 2016 20:28:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 14, 2016, 1:28 p.m.)

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Reviving this chain.  Rebased on Neil's memory leak fixes.

Summary (updated)

Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

Bugs: MESOS-3910

Repository: mesos

Description (updated)

The `SocketManager` and `ProcessManager` are highly inter-dependent, 
which requires some untangling in `process::finalize`.

* Logic originally found in `~ProcessManager` has been split into 
  `ProcessManager::finalize` due to what happens during cleanup.
* The future from `__s__->accept()` must be explicitly discarded as 
  libevent does not detect a locally closed socket.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp afeddec20495bb9621c3e26b0d425c9419654739 



`make check` (libev)
`make check` (--enable-libevent --enable-ssl)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message