mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46163: Exposed state/{state,storage}.hpp files.
Date Thu, 14 Apr 2016 17:57:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46163/#review128929
-----------------------------------------------------------




src/Makefile.am (line 174)
<https://reviews.apache.org/r/46163/#comment192374>

    I think the mesos.internal.state.Entry in state.proto needs to be expose. However, mesos.internal.state.Operation
is impl. details for log storage, and should not be exposed.



src/tests/state_tests.cpp (lines 49 - 52)
<https://reviews.apache.org/r/46163/#comment192378>

    I think we should expose them as well. We definitely need state/protobuf.hpp and state/log.hpp.
But it doesn't make sense to just expose log storage and leave the rest in private.


- Jie Yu


On April 13, 2016, 11:49 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46163/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 11:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
>     https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed state/{state,storage}.hpp files.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 4fd43ca31c6917e81ea1b331b8507ca42a2249cf

>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp fb3c5418220f66c6320581033ee7963de47eafd3

>   src/java/jni/org_apache_mesos_state_LogState.cpp 528fe5367f55c63916cd4990abcc3c137e77cfec

>   src/java/jni/org_apache_mesos_state_Variable.cpp 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec

>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/messages/state.proto  
>   src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
>   src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
>   src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
>   src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
>   src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
>   src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46163/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message