mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.
Date Thu, 14 Apr 2016 10:45:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46135/#review128872
-----------------------------------------------------------



Looks good. Fix these issues (mine and AlexR's) and we can commit it.
BTW, I'm fine with AlexR shepherding this, if he deems it Shippable before I get back to it.


src/tests/master_allocator_tests.cpp (line 1520)
<https://reviews.apache.org/r/46135/#comment192332>

    s/flags/masterFlags/ here, since we have `flags = this->CreateSlaveFlags();` below.



src/tests/master_allocator_tests.cpp (line 1604)
<https://reviews.apache.org/r/46135/#comment192333>

    +1 to using Future<Nothing> with FutureSatisfy since you're not validating the contents
of the Resources.


- Adam B


On April 12, 2016, 8:21 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46135/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 8:21 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5146
>     https://issues.apache.org/jira/browse/MESOS-5146
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pause the clock and make sure all resources from rescinded
> offers are recovered before doing a batch allocation.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp 404ff098baf89bf2a1c6e32424d591a6ea1a093c 
> 
> Diff: https://reviews.apache.org/r/46135/diff/
> 
> 
> Testing
> -------
> 
> Make && Make check.
> 
> ```
> Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter,
mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter>
>
> [ RUN      ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [       OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (385 ms)
> [----------] 1 test from MasterAllocatorTest/0 (386 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (396 ms total)
> [  PASSED  ] 1 test.
> 
> ```
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message