mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).
Date Thu, 14 Apr 2016 04:55:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46134/#review128835
-----------------------------------------------------------


Ship it!




It looks like the ReviewBot ran between the two most recent updates, so it failed on the uninstall
(which is now fixed).  Could you push this review one more time to trigger the ReviewBot again
to verify that it actually works? (I tested locally and it seems to).

- Kevin Klues


On April 14, 2016, 4:24 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46134/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 4:24 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [#mesos-3782]
>     In this patch, we did the following change:
>     1. Change the libprocess cmake target to use 'mesos-agent'
>     instead of 'mesos-slave'
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652

> 
> Diff: https://reviews.apache.org/r/46134/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message