mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.
Date Thu, 14 Apr 2016 02:39:36 GMT


> On April 12, 2016, 2:37 p.m., Joris Van Remoortere wrote:
> > There is no JIRA for this.
> > Initializing the winsock system seems like functionality that belongs in a helper
function rather than inside a test?
> > How is libprocess going to initialize it? What about mesos?
> > I'm guessing we'll want to have something like:
> > ```
> > Try<Nothing> winsock_initialize = winsock_initialize();
> > ...
> > ```
> > 
> > and do this in `libprocess::initialize()`
> > 
> > Thoughts?
> 
> Alex Naparu wrote:
>     This should likely be wrapped in the constructor of a class, while WSACleanup should
be called from the destructor.
> 
> Alex Naparu wrote:
>     This: https://github.com/dpravat/mesos/commit/5b2e549737edcb6a8522026e01b8f4ed70da4d9f

Alex is right.

But, to make progress I've implemented what you've asked for. :)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46008/#review128410
-----------------------------------------------------------


On April 14, 2016, 2:39 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46008/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Initialize Windows socket stack in Stout tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp b5aeab75c2365a3431c397743b95ce7fbd6d7a1a

>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f

> 
> Diff: https://reviews.apache.org/r/46008/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message