mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46168: Add subdirectory support to URI.filename field.
Date Wed, 13 Apr 2016 23:46:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46168/#review128800
-----------------------------------------------------------



Bad patch!

Reviews applied: [46168]

Failed command: ./support/apply-review.sh -n -r 46168

Error:
2016-04-13 23:46:57 URL:https://reviews.apache.org/r/46168/diff/raw/ [7349/7349] -> "46168.patch"
[1]
Total errors found: 0
Checking 4 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12511/console

- Mesos ReviewBot


On April 13, 2016, 9:37 p.m., Michael Browning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46168/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5119
>     https://issues.apache.org/jira/browse/MESOS-5119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add subdirectory support to URI.filename field.
> 
> URI.filename allows the user to specify the name of the file that will be saved in the
sandbox when the URI is fetched, but previously it would fail at fetch time if "filename"
had a directory component. This change allows users to specify a relative path for custom
filenames within the sandbox.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher.md fd6d8a78bd35c5644dceff7005dd7dfd9f5f2171 
>   src/launcher/fetcher.cpp 47583eeaed53b3e7ed4db26fee7cdd2fae5e0c9d 
>   src/slave/containerizer/fetcher.cpp d5910ad570371ba54580be5bb94344a1de38d1f9 
>   src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e 
>   src/tests/fetcher_tests.cpp 23a8dc5f4402c5613744753284aabbe3d09bf797 
> 
> Diff: https://reviews.apache.org/r/46168/diff/
> 
> 
> Testing
> -------
> 
> Three tests were added. In fetcher_tests.cpp, CustomFilenameSubdirectory tests that the
fetcher creates a file in a specified subdirectory in the sandbox, and AbsoluteCustomSubdirectoryFails
tests that a custom filename with an absolute path is rejected. In fetcher_cache_tests.cpp,
CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched
from the cache.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message