mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46173: Added a slave post fetch hook.
Date Wed, 13 Apr 2016 23:17:25 GMT


> On April 13, 2016, 10:59 p.m., Adam B wrote:
> > src/hook/manager.hpp, lines 69-70
> > <https://reviews.apache.org/r/46173/diff/1/?file=1343459#file1343459line69>
> >
> >     Is this all the information the hook will need? Can it easily get from a containerId
to a task/executorId and Info?

Yes. At least for now. I would expect this hook typically performing a scan in the sandbox
directory, adding/removing files.


> On April 13, 2016, 10:59 p.m., Adam B wrote:
> > src/slave/containerizer/docker.cpp, lines 1080-1084
> > <https://reviews.apache.org/r/46173/diff/1/?file=1343461#file1343461line1080>
> >
> >     Are you confident that we want this hook to run before persistent volumes are
mounted?
> >     Maybe what we really want is a slavePreLaunchExecutorContainerHook? Or maybe
we'll have to have both in the future?

If that's necessary, we can have both. I think the reason I called it "postFetch" is because
this hook is supposed to do operations on the fetched artifacts.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46173/#review128789
-----------------------------------------------------------


On April 13, 2016, 10:30 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46173/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 10:30 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5209
>     https://issues.apache.org/jira/browse/MESOS-5209
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a slave post fetch hook.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 87e01a9dccb04bfdd5395867a45c46574815731b 
>   src/hook/manager.hpp 3af28a76493a95a3427fecb3a23dd80ecb84dfe9 
>   src/hook/manager.cpp 17a42f8362f58f0857acabeb2c3113354589fa1b 
>   src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be 
>   src/slave/containerizer/mesos/containerizer.cpp c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440

> 
> Diff: https://reviews.apache.org/r/46173/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message