> On April 12, 2016, 8:24 p.m., Vinod Kone wrote:
> > src/launcher/http_command_executor.cpp, lines 296-297
> > <https://reviews.apache.org/r/44424/diff/8/?file=1338080#file1338080line296>
> >
> > No need to capture taskId because you can get it from `task`?
>
> Qian Zhang wrote:
> I think just capuring `task` is not enough, because `task` will be set to `None()`
when we receive `ACKNOWLEDGED` event, but after that we will still need `taskId`, e.g., in
`reap()`, or when we receive `KILL` or `SHUTDOWN` event.
Oh I see. You can drop this then.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review128522
-----------------------------------------------------------
On April 13, 2016, 9:13 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 9:13 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated http_command_executor.cpp to use v1 API.
>
>
> Diffs
> -----
>
> src/launcher/http_command_executor.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44424/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
|