mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46117: Added `None()` for credentials when creating scheduler lib.
Date Wed, 13 Apr 2016 22:13:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46117/#review128768
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 12, 2016, 10:25 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46117/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 10:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4459
>     https://issues.apache.org/jira/browse/MESOS-4459
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change defaults the credentials argument to `None()` for
> command scheduler/example HTTP framework/long lived framework when
> creating the scheduler library object.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
>   src/examples/long_lived_framework.cpp 853e676b08897c8ae63861d9d51173caa2c1bb3f 
>   src/examples/test_http_framework.cpp cba520e326ff8b0b4ed36a0f4cea6879b57f400c 
> 
> Diff: https://reviews.apache.org/r/46117/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message