mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.
Date Wed, 13 Apr 2016 21:36:22 GMT


> On April 12, 2016, 11:10 p.m., Alex Naparu wrote:
> >

Hey, sorry, you reviewed an old version of the code. I had a different branch checked out
when I pushed this. The background is that this is an amalgamation of maybe 3 or 4 commits,
and the code is not amazing. I went through and fixed up a bunch of stuff on behalf of others,
since they don't have the cycles to deal with it themselves.

Anyway, all this is to say: I've pushed a new revision, so most of these comments will be
addressed incidentally -- things like `exists` being a parameter, stout naming conventions,
etc.

Sorry for the confusion.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review128565
-----------------------------------------------------------


On April 13, 2016, 9:33 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:33 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
>     https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message