mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.
Date Wed, 13 Apr 2016 10:07:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44336/
-----------------------------------------------------------

(Updated April 13, 2016, 10:07 a.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Rebased.


Repository: mesos


Description
-------

We should not enumerate variables if the corresponding instance is the
only one of such type in the test.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 03064da4a5feda0d64db6175c7d5a8e3122bb67a 

Diff: https://reviews.apache.org/r/44336/diff/


Testing
-------

On Mac OS 10.10.4:

`make check`

`GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure
--gtest_shuffle`


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message