-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46135/#review128640
-----------------------------------------------------------
src/tests/master_allocator_tests.cpp (line 1604)
<https://reviews.apache.org/r/46135/#comment192122>
If you're not doing any checks with resources, you can use `Future<Nothing>` instead.
src/tests/master_allocator_tests.cpp (line 1637)
<https://reviews.apache.org/r/46135/#comment192121>
You don't need this `settle()`.
- Alexander Rukletsov
On April 13, 2016, 3:21 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46135/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 3:21 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rukletsov.
>
>
> Bugs: MESOS-5146
> https://issues.apache.org/jira/browse/MESOS-5146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Pause the clock and make sure all resources from rescinded
> offers are recovered before doing a batch allocation.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp 404ff098baf89bf2a1c6e32424d591a6ea1a093c
>
> Diff: https://reviews.apache.org/r/46135/diff/
>
>
> Testing
> -------
>
> Make && Make check.
>
> ```
> Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter,
mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter>
>
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (385 ms)
> [----------] 1 test from MasterAllocatorTest/0 (386 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (396 ms total)
> [ PASSED ] 1 test.
>
> ```
>
>
> Thanks,
>
> Yongqiao Wang
>
>
|