mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 45670: Added tests for HTTP command executor.
Date Wed, 13 Apr 2016 09:09:53 GMT


> On April 13, 2016, 5:11 a.m., Vinod Kone wrote:
> > src/tests/command_executor_tests.cpp, line 67
> > <https://reviews.apache.org/r/45670/diff/3/?file=1338095#file1338095line67>
> >
> >     This is not really a type, this is a bool.
> >     
> >     s/ExecutorType/IsHTTPCommandExecutor/

Thanks for the comment! And I think we do not need `Is`, just `HTTPCommandExecutor` should
be OK, because I see the registrar tests(https://github.com/apache/mesos/blob/0.28.0/src/tests/registrar_tests.cpp#L196)
also uses a bool parameter and names it as `Strict` rather than `IsStrict`.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review128535
-----------------------------------------------------------


On April 9, 2016, 4:48 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/command_executor_tests.cpp 843233adaa68ab1f5cedb7b075439bb8b77469a8 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message