mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 42342: Added a new test cases for revive offer.
Date Wed, 13 Apr 2016 07:37:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review128627
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 3040)
<https://reviews.apache.org/r/42342/#comment192106>

    s/recovered/declined
    
    framework declines resources, allocator recovers



src/tests/hierarchical_allocator_tests.cpp (line 3046)
<https://reviews.apache.org/r/42342/#comment192108>

    All other tests call it "batch allocation" now. Consistency in naming is important to
avoid confusion!



src/tests/hierarchical_allocator_tests.cpp (line 3077)
<https://reviews.apache.org/r/42342/#comment192107>

    Let's stay consistent and call it "a batch allocation"


- Alexander Rukletsov


On April 10, 2016, 1:18 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 1:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-4387
>     https://issues.apache.org/jira/browse/MESOS-4387
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new test cases for revive offer.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp a5dd57a4e0c244fb099433eb7b5777982698ebfd

> 
> Diff: https://reviews.apache.org/r/42342/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.ReviveOffers"
--verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message