mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 45956: Added the `_isolate` method.
Date Wed, 13 Apr 2016 04:40:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45956/
-----------------------------------------------------------

(Updated April 13, 2016, 4:40 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
-------

Fixed missing quotes in `Failure`.


Bugs: MESOS-4922
    https://issues.apache.org/jira/browse/MESOS-4922


Repository: mesos


Description
-------

Once the `isolate` is successful, the `_isolate` method calls out the
`mesos-cni-helper` to setup the /etc/hosts, /etc/hostname and
/etc/resolv.conf for the container.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 654137c552a7c416f394365e43ea80770fe1ef8d

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 159152a01b68a667dbd57fa6452c6c2a3422787c


Diff: https://reviews.apache.org/r/45956/diff/


Testing
-------

make

*Ran mesos_execute with single master/slave setup to verify that containers get the right
hostname and network files when attached to a CNI network.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message