mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.
Date Wed, 13 Apr 2016 02:44:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128604
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46083, 46084, 46085]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 12, 2016, 8:04 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
> 
> 
> Bugs: MESOS-5152
>     https://issues.apache.org/jira/browse/MESOS-5152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to agent's /monitor/statistics endpoint.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
>   src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
>   src/slave/slave.cpp f3913c07b20fc759bbddb85921388e4c64cb49d9 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
> 
> Diff: https://reviews.apache.org/r/46085/diff/
> 
> 
> Testing
> -------
> 
> make check (clang w/o optimization, OS X)
> 
> Additionally confirmed with an actual test cluster setup.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message