mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Naparu <alex.nap...@outlook.com>
Subject Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.
Date Wed, 13 Apr 2016 02:38:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44123/#review128602
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 86)
<https://reviews.apache.org/r/44123/#comment192052>

    Is it worth handling the error case here?



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 164)
<https://reviews.apache.org/r/44123/#comment192053>

    Do we no longer have a "not implemented" error?



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 228)
<https://reviews.apache.org/r/44123/#comment192054>

    We don't have a X_OK flag in Windows, so we might want to mask that out before calling
`::access`.


- Alex Naparu


On April 11, 2016, 4:20 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44123/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer,
Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: [1/2] Implemented assorted `os::` functions on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/44123/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message