mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.
Date Tue, 12 Apr 2016 22:25:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46114/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-3923
    https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
-------

Currently, we never used to initialize the per principal metrics
that can be accessed by "frameworks/<principal>". Currently, it
only has two metrics that have no relevance for HTTP frameworks
i.e., `messages_received`, `messages_processed` but that might change
in the future if we add more such metrics. It also ensures that
HTTP->PID framework downgrades preserve the metrics and no
additional logic is needed to deal with this. (Previously
HTTP frameworks never had AuthN and no principal was passed
in `FrameworkInfo`, so this was never a concern).


Diffs
-----

  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 

Diff: https://reviews.apache.org/r/46114/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message