mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45670: Added tests for HTTP command executor.
Date Tue, 12 Apr 2016 21:11:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review128535
-----------------------------------------------------------



Are you also planning to update slave recovery tests? Those are the most crucial.


src/tests/command_executor_tests.cpp (line 67)
<https://reviews.apache.org/r/45670/#comment191971>

    This is not really a type, this is a bool.
    
    s/ExecutorType/IsHTTPCommandExecutor/


- Vinod Kone


On April 9, 2016, 8:48 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/command_executor_tests.cpp 843233adaa68ab1f5cedb7b075439bb8b77469a8 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message