mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46003: Removed the default value for agent work_dir.
Date Tue, 12 Apr 2016 17:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46003/
-----------------------------------------------------------

(Updated April 12, 2016, 5:45 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed comments.


Bugs: MESOS-5064
    https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
-------

The default value for the agent's `--work_dir` flag was removed, the
type of the parameter was changed to `Option<string>`, and code was
added to explicitly set the work directory when necessary.


Diffs (updated)
-----

  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
  src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
  src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
  src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce


Diff: https://reviews.apache.org/r/46003/diff/


Testing
-------

`sudo make check`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message