mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.
Date Tue, 12 Apr 2016 15:12:14 GMT


> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48
> > <https://reviews.apache.org/r/46009/diff/1/?file=1339064#file1339064line48>
> >
> >     Are you missing an entry in `3rdparty/libprocess/3rdparty/Makefile.am`?

I see it's the subsequent review.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46009/#review128420
-----------------------------------------------------------


On April 11, 2016, 8:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46009/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 8:31 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[1/2] Added simple tests for `os::` functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b

>   3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp d5a96ad6b8b1c09b4f016e0c8e3e5c5672b55ef3

> 
> Diff: https://reviews.apache.org/r/46009/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message