mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.
Date Tue, 12 Apr 2016 15:00:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43522/#review128418
-----------------------------------------------------------




src/tests/oversubscription_tests.cpp (line 1129)
<https://reviews.apache.org/r/43522/#comment191841>

    I observe this test taking more than 1s on my machine. I believe we should make sure resources
are recovered before we advance the clock. Adding `settle()` should do the job.
    
    I wonder why you haven't observed that at least once when running tests in repetition.


- Alexander Rukletsov


On April 9, 2016, 6:16 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43522/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 6:16 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4171
>     https://issues.apache.org/jira/browse/MESOS-4171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover by
> advance allocation interval.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 23671746da2ac505d75bc2bd59114697d9161d52 
> 
> Diff: https://reviews.apache.org/r/43522/diff/
> 
> 
> Testing
> -------
> 
> Repeat test on CentOS 7.1
> 
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover"
--gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message