mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.
Date Tue, 12 Apr 2016 14:37:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46008/#review128410
-----------------------------------------------------------



There is no JIRA for this.
Initializing the winsock system seems like functionality that belongs in a helper function
rather than inside a test?
How is libprocess going to initialize it? What about mesos?
I'm guessing we'll want to have something like:
```
Try<Nothing> winsock_initialize = winsock_initialize();
...
```

and do this in `libprocess::initialize()`

Thoughts?

- Joris Van Remoortere


On April 11, 2016, 8:28 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46008/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Initialize Windows socket stack in Stout tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f

> 
> Diff: https://reviews.apache.org/r/46008/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message