mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 46083: Used already forward-declared process::http::OK.
Date Tue, 12 Apr 2016 13:46:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46083/#review128395
-----------------------------------------------------------



Can you please improve the **Description** field, I find it very hard to understand (removing
it altogether is an option too).

- Alexander Rojas


On April 12, 2016, 3:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46083/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 3:06 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
> 
> 
> Bugs: MESOS-5152
>     https://issues.apache.org/jira/browse/MESOS-5152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If we would e.g., make definitions in `mesos::http` visible using
> `http::OK` in a test would look for `OK` in `mesos::http` instead of
> the intended `process::http`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
> 
> Diff: https://reviews.apache.org/r/46083/diff/
> 
> 
> Testing
> -------
> 
> make check (clang, w/o optimization, OS X)
> 
> Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp`
leads to a compilation failure.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message