mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 46084: Added needed forward-declaration for InternalServerError.
Date Tue, 12 Apr 2016 13:06:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46084/
-----------------------------------------------------------

Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.


Bugs: MESOS-5152
    https://issues.apache.org/jira/browse/MESOS-5152


Repository: mesos


Description
-------

As currently written the code relies on `process::http` being the only
visible namespace with name `http`, an assumption which will break as
soon as we introduce declarations from `mesos::http`.

Fix this as customary by explicitly pulling the needed name into the
local name lookup scope.


Diffs
-----

  src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 

Diff: https://reviews.apache.org/r/46084/diff/


Testing
-------

make check (clang, w/o optimization, OS X)

Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp`
leads to a compilation failure.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message